search

nissl-lab / npoi

a .NET library that can read/write Office formats without Microsoft Office installed. No COM+, no interop.
Apache License 2.0
5.67k stars 1.42k forks source link

Some patches ported from poi #1316

Closed antony-liu closed 4 months ago

antony-liu commented 4 months ago

POI Bug 60255 POI Bug 60284 POI Bug 60288

antony-liu commented 4 months ago

@tonyqus Can you merge this PR first? There are many patches of poi 3.16 to merge.

lahma commented 4 months ago

The tests don't pass?

antony-liu commented 4 months ago

I merge master to poi/v3.16-patch3, and tests passed in windows. I think there was a bug on master before, and it has already been fixed.

tonyqus commented 4 months ago

@antony-liu I add some review comments. Can you see it?

tonyqus commented 4 months ago

This PR should fix #1299

@Bykiev Why do you think this PR can fix the slowness issue?

Bykiev commented 4 months ago

This PR should fix #1299

@Bykiev Why do you think this PR can fix the slowness issue?

https://bz.apache.org/bugzilla/show_bug.cgi?id=60288

antony-liu commented 4 months ago

@antony-liu I add some review comments. Can you see it?

Where is the review comments.

tonyqus commented 4 months ago

LGTM