search

nissl-lab / npoi

a .NET library that can read/write Office formats without Microsoft Office installed. No COM+, no interop.
Apache License 2.0
5.65k stars 1.42k forks source link

More patches ported from poi 3.16 #1342

Closed antony-liu closed 3 months ago

antony-liu commented 3 months ago

More patches ported from poi 3.16

tonyqus commented 3 months ago

Tests failed. Can you check the problem?

antony-liu commented 3 months ago

The test TestXSSFWorkbook.TestSetVBAProject was passed on my local, but failed with PR action. So ignore this test to make PR action pass.

tonyqus commented 3 months ago

The error looks a bit weird. Is it possible it only occurs in chance? Let's remove the ignore tag and trigger it again

Error: ICSharpCode.SharpZipLib.Zip.ZipException : EOF in header
  10:28:45 [DBG] 
  10:28:45 [DBG]   Failed TestSetVBAProject [11 ms]
  10:28:45 [DBG]   Error Message:
  10:28:45 [DBG]    ICSharpCode.SharpZipLib.Zip.ZipException : EOF in header
  10:28:45 [DBG]   Stack Trace:
  10:28:45 [DBG]      at ICSharpCode.SharpZipLib.Zip.Compression.Streams.InflaterInputBuffer.ReadLeByte()
  10:28:45 [DBG]    at ICSharpCode.SharpZipLib.Zip.ZipInputStream.SkipUntilNextEntry()
  10:28:45 [DBG]    at ICSharpCode.SharpZipLib.Zip.ZipInputStream.GetNextEntry()
  10:28:45 [DBG]    at NPOI.OpenXml4Net.Util.ZipInputStreamZipEntrySource..ctor(ZipInputStream inp) in /_/openxml4Net/Util/ZipInputStreamZipEntrySource.cs:line 35
  10:28:45 [DBG]    at NPOI.OpenXml4Net.OPC.ZipPackage..ctor(FileInfo file, PackageAccess access) in /_/openxml4Net/OPC/ZipPackage.cs:line 119
  10:28:45 [DBG]    at NPOI.OpenXml4Net.OPC.OPCPackage.Open(FileInfo file, PackageAccess access) in /_/openxml4Net/OPC/OPCPackage.cs:line 264
  10:28:45 [DBG]    at TestCases.XSSF.UserModel.TestXSSFWorkbook.TestSetVBAProject() in /_/testcases/ooxml/XSSF/UserModel/TestXSSFWorkbook.cs:line 907
antony-liu commented 3 months ago

I have removed the ignore attribute, and the test passed.

tonyqus commented 3 months ago

LGTM