Added support for \n in text elements

nissl-lab / npoi

a .NET library that can read/write Office formats without Microsoft Office installed. No COM+, no interop.

Apache License 2.0

5.74k stars 1.43k forks source link

Added support for \n in text elements #1346

Closed pbvs closed 2 months ago

pbvs commented 6 months ago

This is a pull request for fixing #1260 for discussion on this change. (resolves #1260)

In short there are two changes:

When writing CT_Text to XML \n is replaced by the cml element
When reading parsing xml the element is replaced by \n I added a unit test to check that everything is replaced as expected.

Please let me know if i need to make additional changes.

Regards, Pieter

Bykiev commented 6 months ago

Can you please check failed tests?

tonyqus commented 2 months ago

any update?

pbvs commented 2 weeks ago

@tonyqus sorry for the long wait, i checked in my environment and all units are working now. I also see that you fixed / finished my changes and merged them to main. Thanks for this, if you need any assistance on this issue please let me know.

regards Pieter