nissl-lab / npoi

a .NET library that can read/write Office formats without Microsoft Office installed. No COM+, no interop.
Apache License 2.0
5.65k stars 1.42k forks source link

Added support for \n in text elements #1346

Open pbvs opened 3 months ago

pbvs commented 3 months ago

This is a pull request for fixing #1260 for discussion on this change. (resolves #1260)

In short there are two changes:

  1. When writing CT_Text to XML \n is replaced by the cml element
  2. When reading parsing xml the element is replaced by \n I added a unit test to check that everything is replaced as expected.

Please let me know if i need to make additional changes.

Regards, Pieter

Bykiev commented 3 months ago

Can you please check failed tests?