nissl-lab / npoi

a .NET library that can read/write Office formats without Microsoft Office installed. No COM+, no interop.
Apache License 2.0
5.73k stars 1.43k forks source link

maxRows is usefull for AutoSizeColumn and GetColumnWidth #1403

Closed PatriceDargenton closed 2 months ago

PatriceDargenton commented 2 months ago

maxRows is usefull for AutoSizeColumn and GetColumnWidth from outside the library NPOI. maxRows was added few years ago (https://github.com/nissl-lab/npoi/pull/723), but it is usefull for AutoSizeColumn and GetColumnWidth in fact. The change also for AutoSizeColumn is needed in order to respect interface implementation: AutoSizeColumn(column, useMergedCells, maxRows: 0);

tonyqus commented 2 months ago

LGTM