search

nitaigao / gulp-s3

MIT License
101 stars 82 forks source link

add require("fs") in README example #43

Closed adam187 closed 7 years ago

adam187 commented 9 years ago

@cworsley4 require() is for module loading and aws.json is plain json file.

cworsley4 commented 9 years ago

Require doesn't care about that. It will read the file and parse the json for you. @adam187

adam187 commented 9 years ago

@cworsley4 Interesting, i didn't knew that require() in node can do that. In spite of that this example isn't Mine. I only added missing module loading to complete example and make it workable.

cworsley4 commented 9 years ago

@adam187 Ah, I see. I submitted a PR today that corrected that. We'll see if it gets accepted.

gravitypersists commented 9 years ago

Might want to include var gulp = require('gulp') while at it?

cworsley4 commented 9 years ago

So the changes in this PR are in my fork of this repo. The repo is abandoned. Check out... https://github.com/cworsley4/gulp-s3-ls.

On Wed, May 27, 2015 at 2:42 PM, Michael Silveira notifications@github.com wrote:

Might want to include var gulp = require('gulp') while at it?

— Reply to this email directly or view it on GitHub https://github.com/nkostelnik/gulp-s3/pull/43#issuecomment-106028313.