Closed toolness closed 7 years ago
Hey, I noticed in the code that errors appear to be logged but then nothing is done about them:
client.putBuffer(file.contents, uploadPath, headers, function(err, res) { if (err || res.statusCode !== 200) { gutil.log(gutil.colors.red('[FAILED]', file.path + " -> " + uploadPath)); } else { gutil.log(gutil.colors.green('[SUCCESS]', file.path + " -> " + uploadPath)); res.resume(); } });
It would be nice if an error event or something was emitted, so that gulp tasks could raise errors instead of having the process exit with status code 0 even though things went amiss.
+1
Fixed in: https://github.com/nitaigao/gulp-s3/commit/f3a46731b608b88588280ae23c0feefa080e2c3f
Thank you @nitaigao :)
Hey, I noticed in the code that errors appear to be logged but then nothing is done about them:
It would be nice if an error event or something was emitted, so that gulp tasks could raise errors instead of having the process exit with status code 0 even though things went amiss.