nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Update mapbox-android-sdk to 6.1? #1197

Open jshearer opened 6 years ago

jshearer commented 6 years ago

Hi! I'm using this library in my app, and noticed some subtile but annoying interaction issues where the map doesn't do exactly what I would expect, when compared to, for example, google maps, or maps on iOS.

Examples of the things that feel weird:

I had originally just accepted these minor issues as mapbox not having the bandwidth to spend developer hours on fine tuning map interactions like google/apple does, but I saw the blog post about revamping gestures for android:

https://blog.mapbox.com/revamping-gestures-for-android-maps-e298a7a2832a

I couldn't find any references to AndroidGesturesManager in this library, and it seems that the revamped gesture detection was introduced in version 6+ of the underlying mapbox-gl-native library, which gets used in mapbox-android-sdk here. But looking at master, it looks like that dependency hasn't been updated for 2 months:

https://github.com/mapbox/react-native-mapbox-gl/blob/548b91c66eb56bdd3e63071922de7ab2936e2474/android/rctmgl/build.gradle#L31

Are there technical reasons preventing the update? Is it a major breaking change? Is it being worked on? Can I contribute to that effort in any way?

Thanks!

nitaliano commented 6 years ago

@jshearer it's a very large breaking change, that we will be taking on in June. The only "technical reason" is I've switched focus from this SDK to a different React Native project. My focus will be back on this project in June.

jshearer commented 6 years ago

Ah, thanks for the response :) Is this library getting replaced? Or you've just been working on a completely orthogonal project?

nitaliano commented 6 years ago

nope this library is not getting replaced, in fact more resources are going to be added to it. I'm the only React Native dev at Mapbox at the current moment, but that is going to be changing. We have plans to release more React Native SDKs to cover other parts of our stack, which is what I'm working on now.

olegdater commented 6 years ago

@nitaliano nice to hear this!! Because it starts to look like this package is abandoned :( Looking forward to more activity!

mrtnzlml commented 6 years ago

@nitaliano Hi, can you please tell us what is the status here? 🙂