search

nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Overriding the attribution menu? #1201

Open hampelm opened 6 years ago

hampelm commented 6 years ago

After a few successful public releases, Apple's reviewers are now complaining that:

Your app's location feature is not integrated with the built-in mapping functionality, which limits users to a third-party maps app.

Next Steps

To resolve this issue, please revise your app to give users the option to launch the native Apple Maps app.

And then they attach a screenshot with the map attribution expanded. I'm going back and forth with them, but if that fails, (a) is there a known workaround for the Mapbox SDK (I didn't see anything in some cursory googling), and (b) is there a way for me to override or extend that attribution panel to include a custom link? Seems like that might solve the problem for them.

attachment-6674981129091964827screenshot_0515_095817
jshearer commented 6 years ago

I realize that this isn't relevant to your question, but how did you add the button on the top right of your map? I've been trying to figure out how to do that for a while now.

hampelm commented 6 years ago

@jshearer we positioned a component on top of the map. Here are the rough styles: https://gist.github.com/hampelm/cdc0c4dcdbc91c4e4c8ef4ccff0d4287

hampelm commented 6 years ago

Writing a detailed explanation of why we needed mapbox got us past the review. Would still be interesting to know if the info menu can be customized, eg to add our own attribution for the data we layer on top.