search

nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 699 forks source link

v7 PR references unavailable branch of mapbox-sdk-js #1390

Open wdimmit opened 5 years ago

wdimmit commented 5 years ago

The v7 PR (as of ffb3c92) contains a package.json that references the #revitalized branch of the mapbox-sdk-js project. This branch does not seem to be publicly available.

zugaldia commented 5 years ago

Hey @wdimmit - thanks for the feedback. Could you point me at the file where you're seeing this? Can't currently see that reference in https://github.com/mapbox/react-native-mapbox-gl/blob/expressions/package.json.

Edit: fixed link.

wdimmit commented 5 years ago

@zugaldia My apologies for the unclear bug report. The package.json in question is actually the one in the examples project. https://github.com/mapbox/react-native-mapbox-gl/blob/expressions/example/package.json

zugaldia commented 5 years ago

No worries @wdimmit and thanks. It seems this is where the branch in question was deleted https://github.com/mapbox/mapbox-sdk-js/pull/217. This PR is now merged, could you try rebuilding the app removing the revitalized branch constrain?

wdimmit commented 5 years ago

@zugaldia Further testing of this issue is blocked by https://github.com/mapbox/react-native-mapbox-gl/issues/1389 at the moment. I'll be happy to retest once it is possible. Cheers!