Fix Android UIManager deprecation warning for RN 0.58

nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps

Other

2.16k stars 697 forks source link

Closed marudy closed 5 years ago

kristfal commented 5 years ago

@marudy is this backwards compatible? If so, how far back?

goodryanboy commented 5 years ago

Is there any workaround here?

kristfal commented 5 years ago

This will break RN 0.57 or lower. Can you add a fallback for those versions?

kristfal commented 5 years ago

Closing this. Will accept a PR with a fallback for lower versions of RN.

alexiri commented 5 years ago

Hi @kristfal, you rejected this PR but you introduced the change anyway as part of 88f9f7f9279031417a3964c5567a2b77577fbf99. Was this intentional?

kristfal commented 5 years ago

Hey, that was not intentional. I think it should have been reversed.