search

nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Podspec fix for people using CocoaPods for distribution and not NPM #1504

Closed orta closed 5 years ago

orta commented 5 years ago

Typically during the install process npm calls node ./scripts/download-mapbox-gl-native-ios-if-on-mac.js 3.7.8 to download the MapBox SDK: here

However, when you install this library via CocoaPods (when separating your JS / native code ) then this script doesn't run. This allows CocoaPods consumers to also get a copy of the framework.

nitaliano commented 5 years ago

@orta what will happen if I pull in the native mapbox ios sdk thru my podfile?

orta commented 5 years ago

Hrm, good Q, let's see how that works - might be able to close this

orta commented 5 years ago

Looking good, I get framework conflicts. Perhaps this PR can be switched to documentation on the README.

nitaliano commented 5 years ago

@orta thanks for checking it out, I with updating the documentation on this PR and we can get it merged in.

orta commented 5 years ago

Happy to see where this goes instead: https://github.com/nitaliano/react-native-mapbox-gl/pull/1533