search

nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Documentation - iOS #1506

Open ddolheguy opened 5 years ago

ddolheguy commented 5 years ago

Hey guys,

Can someone PLEASE remove the reference to "'RCTTest'," in the iOS pods setup. This is just wrong and cases a lot of issues for newbies since they just copy/paste it out. RCTTest does not support BitCode (which the base RN project has enabled) and even I myself spend about 40 mins chasing my tail until I found out this package was the issue.

https://github.com/mapbox/react-native-mapbox-gl/blob/master/ios/install.md

ferdicus commented 5 years ago

feel free to help out and open a PR, this repo is now community driven

winseyli commented 5 years ago

I had the same thought when my issue was resolved after reading this thread #1244 Is there any reason that we can't remove RCTTest from the pod 'React' list? I am happy to open a PR for this if it helps..

systemlevel commented 5 years ago

@ddolheguy @winseyli Thanks for letting us know. Can you suggest exact changes to our docs here https://github.com/react-native-mapbox/maps/blob/master/ios/install.md : I don't use pods, any exact change recommendations you have is welcome. Thanks!

systemlevel commented 5 years ago

@ddolheguy @winseyli See this PR and please leave any feedback for additional changes you see may be required: https://github.com/react-native-mapbox/maps/pull/29

winseyli commented 5 years ago

@systemlevel Thanks that's the row to be removed :)