Open onitzschke opened 5 years ago
L-Yeiser
commented
5 years ago We have started to see this crash in our googlePlay crash analytics. No idea what is causing it and have been unable to reproduce it. There is also [this]()https://github.com/mapbox/react-native-mapbox-gl/issues/1102) issue but our app is locked to portrait mode.
We are currently on RN 0.57 and react-native-mapbox-gl 6.1.3. Currently in the process of upgrading to RN 0.58.
kristfal
commented
5 years ago Can you try defining the map view style as:
position: 'absolute',
top: 0,
bottom: 0,
left: 0,
right: 0,and see if you can reproduce?
L-Yeiser
commented
5 years ago @kristfal thanks for the suggestion. I will try this in a release.
L-Yeiser
commented
5 years ago @kristfal still seeing the crash. It is our most common crash.
kristfal
commented
5 years ago I’ll need a proper stack trace, cant make much sense of the SS from Bitrise.
Also: Can you share the code for how you set the circleLayer? Also, what range of devices/OS versions are you experiencing this on? How common is the crash? Are you unmounting the map view at any time?
L-Yeiser
commented
5 years ago Here is the code for CircleLayer.
return (
<MapboxGL.ShapeSource
id="campgroundClusters"
clusterRadius={40}
clusterMaxZoomLevel={7}
cluster={cluster}
hitbox={{ width: hitboxSize, height: hitboxSize }}
shape={{
type: 'FeatureCollection',
features: (markers || []),
}}
{...rest}
>
{showCampgroundIcons &&
<MapboxGL.SymbolLayer
id="campgroundIcon"
style={[mapStyles.icon, mapStyles.iconStar]}
filter={['all', ['!has', 'point_count']]}
minZoomLevel={minZoomLevel}
/>
}
{cluster &&
<MapboxGL.CircleLayer
id="campgroundCluster"
style={mapStyles.cluster}
filter={['all', ['>', 'point_count', 1]]}
minZoomLevel={minZoomLevel}
/>
}
{cluster &&
<MapboxGL.SymbolLayer
id="pointCount"
style={mapStyles.clusterCount}
filter={['all', ['>', 'point_count', 1]]}
minZoomLevel={minZoomLevel}
/>
}
</MapboxGL.ShapeSource>
);We are not catching this crash in our other error reporting (Sentry) been trying to figure out why but without that a better stack trace is hard to come by. I will dig into it a bit.
L-Yeiser
commented
5 years ago @kristfal this is currently our number one crash on Android. Is there anything we can do to help debug it. All crash clusters are on Android 9, on a diversity of android devices. We do unmount the map and can also have multiple instances of the same map. We are using react-native-navigation and have a tab based app. There is minimally one map in the stack at all times and four other screens can load a map instance.
kabbi
commented
5 years ago I have the same issue, lots of native crashes. We have a stable map (no dynamic mounting/unmounting), and the issue happens sometimes on updating geojson layer and / or dynamic layers mounting / unmounting.
L-Yeiser
commented
5 years ago Any movement on this or any way we can help debug? All crashes are originating from (com.mapbox.mapboxsdk.maps.renderer.textureview.TextureViewRenderThread$EGLHolder.terminate+22). We are seeing crashes in ~0.5% of sessions.
kristfal
commented
5 years ago That looks deep in the native stack. Your best best is to update to the new repo (see readme) and see if you can reproduce there. That repo uses the latest native map engines instead of the 1+ year old ones at this repo.
The app is randomly crashed with
<MapboxGL.Animated.CircleLayer />In my case it's a pulsing outer circle.