nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Dynamic version for Android Support Library and OKHTTP #1556

Closed sfratini closed 5 years ago

sfratini commented 5 years ago

Hey, so I was having problems building with master, and it was because I was compiling with version 27 and Mapbox was forcing version 28 of the Support Library.

You get issues like this: https://stackoverflow.com/questions/49280632/error9-5-error-resource-androidattr-dialogcornerradius-not-found

So I had to force my compileSdkVersion to 28.

Eventually I made the supportLibVersion dynamic and also the okhttp version since some people were having issues. Bumped the compile version to 28 since it makes sense to have the same as the support library.

kristfal commented 5 years ago

Looks good. Lgtm.