search

nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Bug: Android: Does not compile on Android 28 #1575

Closed mvniekerk closed 5 years ago

mvniekerk commented 5 years ago

Reproduce steps: yarn global add react-native react-native init test cd test/ yarn add @mapbox/react-native-mapbox-gl npm link react-native run-android

Versions Android:

{
        buildToolsVersion = "28.0.0"
        minSdkVersion = 16
        compileSdkVersion = 28
        targetSdkVersion = 26
        supportLibVersion = "28.0.0"
    }

classpath 'com.android.tools.build:gradle:3.3.2'

Fix Change node_modules/@mapbox/react-native-mapbox-gl/android/rctmgl/build.gradle: https://gist.github.com/mvniekerk/07f1c71abff69f81d1aaee548737fea8

kristfal commented 5 years ago

Thanks for reporting. This is fixed in master, just waiting for publish to NPM. We already got an issue for that, so closing.

mvniekerk commented 5 years ago

Excellent. Will wait for the new version.