nitaliano / react-native-mapbox-gl

A Mapbox GL react native module for creating custom maps
Other
2.16k stars 697 forks source link

Fixed Trying to remove a view index above child count 0 #1580

Closed mattijsf closed 5 years ago

mattijsf commented 5 years ago

Fixes a regressed issue: https://github.com/nitaliano/react-native-mapbox-gl/issues/1579

A PR fixing the issue was initially accepted in PR https://github.com/nitaliano/react-native-mapbox-gl/pull/1274 but parts of it were lost in a recent merge (see above issue)

jruddell commented 5 years ago

@mattijsf can we merge this? I have a few crashes because of this issue

mattijsf commented 5 years ago

@jruddell Sure, but I'm not an official maintainer of this repo so I can't do it.

@kristfal Is there anything preventing this to be merged?

sfratini commented 5 years ago

@mattijsf Hey I can merge too. You were the original author of the first PR right? I just want to be sure I am not breaking anything and you know the code already.

mattijsf commented 5 years ago

It is not breaking anything. We are using it in our internal fork which is up-to-date with current master. Like described above, these changes where there before but got lost in a big merge(conflict) some time ago :)

sfratini commented 5 years ago

There you go :)

jruddell commented 5 years ago

thanks guys!