search

nitanmarcel / cinny-click-packaging

Yet another matrix client. Click packaging for locally running on Ubuntu Touch
Other
9 stars 7 forks source link

Start using CMake's ExternalProject feature #20

Open JamiKettunen opened 1 year ago

JamiKettunen commented 1 year ago

As I saw in https://github.com/nitanmarcel/cinny-click-packaging/pull/19#issuecomment-1424941246 the repo currently uses git submodules; would it be possible to start using CMake's ExternalProject feature instead?

I also noticed https://github.com/nitanmarcel/cinny-click-packaging/tree/main/libs/qhttp which appears to just be in-tree copy of https://github.com/azadkuh/qhttp? Similar treatment could be given to that; if it's patched ExternalProject also can handle that.

nitanmarcel commented 1 year ago

As I saw in #19 (comment) the repo currently uses git submodules; would it be possible to start using CMake's ExternalProject feature instead?

I also noticed https://github.com/nitanmarcel/cinny-click-packaging/tree/main/libs/qhttp which appears to just be in-tree copy of https://github.com/azadkuh/qhttp? Similar treatment could be given to that; if it's patched ExternalProject also can handle that.

With qhhtp the thing is that it's a .pri project, and I have no idea if CMake handles that, so the in-tree copy has been made to create a CMakeLists.txt file I can use.

JamiKettunen commented 1 year ago

Worst case scenario is it can be added with a patch file, but it seems there's a PATCH_COMMAND you can use to for example use your own script to do what's needed, or just simply copy the CMakeLists.txt in-place to the SOURCE_DIR of the ExternalProject :)