search

nitaybz / homebridge-sensibo-ac

Homebridge plugin for Sensibo - Smart AC Control
GNU General Public License v3.0
71 stars 15 forks source link

Merge v2.5.1 back to Master - fix for #141 #142

Closed benwebbbenwebb closed 4 months ago

benwebbbenwebb commented 4 months ago

v2.5.1 (from release branch) has a fix for #141 this back merge is to keep master up to date before v2.6 changes are merged to prevent regression defects etc.

The fix for #141 that is included in v2.5.1 is to re-introduce the space in the AC LightSwitch service name, e.g.:

this.roomName + 'AC Light' // was
this.roomName + ' AC Light' // will be

I have also added a check and clean-up function removeLightSwitchFix() to correct any AC LightSwitch services that got created with the 'wrong' name.

benwebbbenwebb commented 4 months ago

Hi @seidnerj - would you mind having a quick look over this before I merge it?

I expect it will mean that at least one or two extra changes need to happen in #136 before it can be merged but seems like good practice to keep master up to date with any fixes that were required on v2.5.x before we merge it.

Thanks

seidnerj commented 4 months ago

Sure - will take a look at this too, when I have a bit of time. Hopefully in the next week or so.

seidnerj commented 4 months ago

looks fine to me, get this merged and then we can get back to #136

benwebbbenwebb commented 4 months ago

Thanks, all done @seidnerj