search

nitaybz / homebridge-sensibo-ac

Homebridge plugin for Sensibo - Smart AC Control
GNU General Public License v3.0
69 stars 15 forks source link

Automation turning on Climate React changes Climate React configuration #148

Open mkrexp opened 1 month ago

mkrexp commented 1 month ago

My automation is configured to automatically turn on climate react at 10:00 PM. When automation is turning on Climate React , Climate React setup is changed automatically ('AC Light' and 'Swing'). My configuration before automation runs is shown below: before

After automation runs configuration is changed as presented below: after

benwebbbenwebb commented 1 month ago

Hi @mkrexp

What automation are you running? Is it as simple as turning on the ClimateReact switch?

Do you have the (new) ClimateReact Auto Setup turned on?

If you are only switching ClimateReact on (or off) via Home app automation then I would expect it to not change the settings configured in the Sensibo app as you expect, however the new Auto Setup mode does “copy” your current settings.

mkrexp commented 1 month ago

Hi, my automations are very simple - has turn on or off climate react switch. Both (turn on or off) override my setup. Auto setup for climate react is turned off because it overrides my setup, so I have turned it off.

W dniu wt., 30.07.2024 o 00:51 Ben @.***> napisał(a):

Hi @mkrexp https://github.com/mkrexp

What automation are you running? Is it as simple as turning on the ClimateReact switch?

Do you have the (new) ClimateReact Auto Setup turned on?

If you are only switching ClimateReact on (or off) via Home app automation then I would expect it to not change the settings configured in the Sensibo app as you expect, however the new Auto Setup mode does “copy” your current settings.

— Reply to this email directly, view it on GitHub https://github.com/nitaybz/homebridge-sensibo-ac/issues/148#issuecomment-2257142064, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6QYV5WD2R3HJCEE6Y23BCLZO3BNLAVCNFSM6AAAAABLUT6QOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXGE2DEMBWGQ . You are receiving this because you were mentioned.Message ID: @.***>

benwebbbenwebb commented 1 month ago

Thanks for the reply @mkrexp

Do you have the Light switch enabled in your settings for this plugin? By the feel of it I think 'defaults' are being used by Sensibo... so if Light isn't set/sent by Home app / Homebridge Sensibo must default it to On.

Similarly for Swing, Apple Home app doesn't support modes other than On / Off, so your setting of 'Fixed top' is being overwritten by the default of 'Stopped (auto)'.

Please let me know your thoughts on this, will help direct further investigations (and any potential fix/changes).

mkrexp commented 1 month ago

Thanks for the reply @benwebbbenwebb

I have the light switch enabled in plugin config. I have asked Sensibo Support if they change anything in climate react settings and they do not change anything.

Before updating from 2.3.4 to 2.5.1, configuration was not overwritten by described automation or when I turned climate react from home app, so I thought something is wrong with plugin, not Sensibo.

benwebbbenwebb commented 1 month ago

Thanks @mkrexp

Agree that it sounds logical for it to be the plugin, I’ll take another look at the code changes.

Would you be able to toggle the light switch a few times, and then change it to your desired setting for ClimateReact (I think Off?) and see if turning on ClimateReact via Home still changes the desired Light setting?

With the Swing mode, that one is going to be harder… Apple don’t support fixed swing positions (like Fixed top) so we don’t expose it. Will need to think about how best to achieve your desired outcome, but still allow others to setup and modify the ClimateReact settings via Home app (rather than having to use Sensibo app).

mkrexp commented 1 month ago

Hi @benwebbbenwebb

Toggling light switch works as turning on/off AC but without turning it on or off, rather like 'settings switcher' - light is turned on/off but swing is also changed. For example, I have AC turned on with light on and swing set to fixed top. After toggle light switch in Home app, on my AC I have light switched to off and swing is changed to 'stopped (auto)'. In logs available in Sensibo app I can see entry 'API call API call(Michal) set the swing to stopped (auto)'. After next toggle of light switch in Sensibo app logs I can see entry 'API call API call API call(Michal) kept state on'.

Maybe you should send only dedicated commands (i.e. 'turn climate react on') without any other parameters? I don't know if Sensibo API allows it, but I suppose that was done in version I used before updating to 2.5.1.

It's very frustrating that I can configure automation for turning on features (like climate react) but I have to remember change climate react settings to my preferences simultaneously

benwebbbenwebb commented 1 month ago

Thanks again @mkrexp for the added info

Hi @seidnerj Looks like some of the changes to ClimateReact and the API calls in the currently version are having negative side effects for some users.

Specifically sending the whole ClimateReact object when enabling (or disabling). As Homebridge/Home app don’t support multiple swing positions the new implementation is overwriting the swing (and light?) setting…

Would appreciate your thoughts on the best way to proceed @seidnerj.

seidnerj commented 1 month ago

Sure, I'll fix that. Will update.

seidnerj commented 3 weeks ago

Hey guys, I'm not sure when I'll get to this, I'm swamped at the moment, will work on this when I can. Sorry!

benwebbbenwebb commented 3 weeks ago

All good @seidnerj

I might try and take a look, see what can be done in the current version…

@mkrexp in the interim, to get your previous process working again, have you tried downgrading back to the v2.3.4 version?

seidnerj commented 3 weeks ago

@benwebbbenwebb 🙏