search

nitayneeman / schematics-utilities

🛠️ Useful exported utilities for working with Schematics
https://nitayneeman.github.io/schematics-utilities
MIT License
86 stars 9 forks source link

refactor: restore @angular/cdk clone #35

Closed nitayneeman closed 4 years ago

nitayneeman commented 4 years ago

This PR restores the source files because of https://github.com/nitayneeman/schematics-utilities/issues/17 (it was removed as part of https://github.com/nitayneeman/schematics-utilities/pull/33).

mraible commented 4 years ago

@nitayneeman I tried switching to this branch. If you look at my PR, you can see that its Angular tests are now failing.

nitayneeman commented 4 years ago

@mraible I've managed to reproduce your issue locally (I cloned your project and linked my local branch). I've pushed a couple of changes that align to the sources of @angular/cdk@8.2.3 - which I think was the mismatch that causing the error.

Would you like to give another try?

mraible commented 4 years ago

@nitayneeman I ran all my tests again after your updates and they pass now. Nice work!