nitely / Spirit

Spirit is a modern Python based forum built on top of Django framework
http://spirit.readthedocs.io
MIT License
1.16k stars 334 forks source link

Private Messages #157

Open cryptogun opened 7 years ago

cryptogun commented 7 years ago

Private message should be differ from private topic. In a private conversation, you should ask for the opposite sides for permission before allowing a new person to join the conversation. Or just disable the invite function for private message.

nitely commented 7 years ago

Private topics are private. The owners of a private topic can invite whoever they want. That's how it works and it's the intended behaviour.

In a private conversation, you should ask for the opposite sides for permission before allowing a new person to join the conversation.

That sounds like a different feature. For example private groups, where a member ask to join in, then they are allowed to view all topics created by that group.

Or just disable the invite function for private message.

What would be the purpose of this? Nothing is really private if everyone involve don't want to keep it private (i.e they can take screen-shots of conversations and so on). Disabling the invite function would be crippling the private topics feature for no good reason, IMHO.

cryptogun commented 7 years ago

Yes, the feature of private topic is great. But many user may think private message is like SMS and meant to be more private then private topic. e.g. a man send a private message(love letter/booty call etc.) to a woman, then she invites many user into this private message, that would be embarrassing.

nitely commented 7 years ago

What keeps the woman from taking a screen-shot and sharing it?

cryptogun commented 7 years ago

He can lie :smiley_cat: Neither can SMS. He should bear it. But SMS is a bit better then private topic. If he needs the invitation feature, he can use private topic. If he needs the SMS feature, we should provide the improved private message functionality.

nitely commented 7 years ago

Well, yeah haha. I guess we could disable the private topic invites and add a "Private Group Topic" where the invites are enabled. But I'm still not convinced about it.

alesdotio commented 7 years ago

I think the current implementation is fine. The only thing I changed on my forum is I separated topic notifications and private message notifications.

cryptogun commented 7 years ago

I just finish copying private folder to SMS folder and modifying SMS for private messages today. I made lots of modifications and now it works. I'll post my site link here once it's finished and up in case someone wanna see the final result. And I'll make some part of it opensource once I'm free. As for PM/SMS, Here are some of the features/modifications:

Con: Since user can modify their comments, that means they can modify the SMS they've sent to your phone. Analogy.