[WIP] case insensitive username

nitely / Spirit

Spirit is a modern Python based forum built on top of Django framework

http://spirit.readthedocs.io

MIT License

1.16k stars 334 forks source link

[WIP] case insensitive username #246

Closed nitely closed 5 years ago

nitely commented 5 years ago

fixes #178

todo:

[x] data migration
[x] case-insensitive mentions
[x] make usernamelower on registrarion, login,
[x] use user.st.nickname on templates
[x] populate user.st.nickname on profile creation
[x] case-insensitivity on private forum invitations
[x] data migration tests
[x] case-insensitive mentions tests
[x] usernamelower on registrarion, login tests
[x] populate user.st.nickname on profile creation tests
[x] case-insensitivity on private forum invitations tests

coveralls commented 5 years ago

Coverage increased (+0.07%) to 97.176% when pulling b10a54b137c9702e2fb1d018e0558788b2f2b918 on usernames_ci into 1bd36089aa6f5e798d5b64528f09ff447e2c4d7a on master.

nitely commented 5 years ago

This is a breaking change. Unless we make the setting off by default, but first I like case-insensitive (CI) usernames better and second the feature can be turned off without running into conflicts, that's not the case when turning it on.