search

nitely / Spirit

Spirit is a modern Python based forum built on top of Django framework
http://spirit.readthedocs.io
MIT License
1.16k stars 332 forks source link

Upgrade/py3.10 dj3.2 #310

Closed imagescape closed 1 year ago

imagescape commented 2 years ago

Upgraded to work with python 3.10 and django 3.2

nitely commented 2 years ago

Would you ping me on the weekend if I don't review it sooner? Ty

On Wed., Jun. 8, 2022, 1:57 p.m. Imaginary Landscape, LLC, < @.***> wrote:

Upgraded to work with python 3.10 and django 3.2

You can view, comment on, or merge this pull request online at:

https://github.com/nitely/Spirit/pull/310 Commit Summary

File Changes

(277 files https://github.com/nitely/Spirit/pull/310/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/nitely/Spirit/pull/310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM6L42HUDMZE56PDI32H6TVOECNHANCNFSM5YH3H6GA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nitely commented 2 years ago

the tests won't pass, so cannot merge. Also, whoosh is not dead https://github.com/whoosh-community/whoosh , and even if it were dead, elastic search cannot be a hard dependency, because it's a service that you need to run, hence is a no-no. Same reason why celery and huey are not hard dependencies.