search

nitely / Spirit

Spirit is a modern Python based forum built on top of Django framework
http://spirit.readthedocs.io
MIT License
1.16k stars 332 forks source link

Not all site users should be listed by spirit #324

Closed sureshvv closed 5 months ago

sureshvv commented 11 months ago

Many members of a site may want to remain unlisted in spirit.

nitely commented 11 months ago

There should be a way to list them, or no way to unset this boolean in Spirit. Otherwise there's no way to reverse the operation if you don't know the user edit URL.

Also, what's the point of this? it does not seem useful on its own.

Also, tests are missing.

sureshvv commented 11 months ago

The UserProfileForm has a checkbox that can be unset to unlist the users. This is done by Spirit admin.

I can write the tests if you are ok with the idea in general.

nitely commented 11 months ago

I don't get it, why would I want to remove a user from the user list?

sureshvv commented 11 months ago

When a single django instance is running multiple independent apps and users from one should not be mixed with the users of another.

nitely commented 11 months ago

those users can still access Spirit, so they are spirit users... In any case this is something that should be done in another app, not in Spirit...

sureshvv commented 11 months ago

Hmmm... Can you tell me how I can make the other app prevent Spirit from listing the users?

You are right in that they would be able to access Spirit unless middleware prevents that.

nitely commented 11 months ago

You can override the template and add a filter there I believe.

sureshvv commented 11 months ago

Good. I will try that.