followup now that https://github.com/nim-lang/Nim/issues/15511 was fixed

nitely / nim-regex

Pure Nim regex engine. Guarantees linear time matching

https://nitely.github.io/nim-regex/

MIT License

225 stars 20 forks source link

followup now that https://github.com/nim-lang/Nim/issues/15511 was fixed #103

Closed timotheecour closed 3 years ago

timotheecour commented 3 years ago

closes https://github.com/nitely/nim-regex/issues/81
addresses https://github.com/nitely/nim-regex/pull/82#issuecomment-719958928
remove a warning

I've dropped support for nim < 1.0 otherwise the change i did via toSeq doesn't work, if for some reason that's not desirable I can use a when to support it. I dont' see much value in supporting nim < 1.0 at this point though (more opportunities for simplifying code).

timotheecour commented 3 years ago

ping @nitely

nitely commented 3 years ago

@genotrance Is it alright with you if we drop support for Nim < 1.0?

genotrance commented 3 years ago

Yes seems about time.