search

nitely / nim-regex

Pure Nim regex engine. Guarantees linear time matching
https://nitely.github.io/nim-regex/
MIT License
225 stars 20 forks source link

Test fail on Nim 1.6 CIs #115

Closed narimiran closed 2 years ago

narimiran commented 2 years ago 
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex.nim(1151, 22) regex
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex.nim(1223, 11) :anonymous
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex.nim(516, 21) match
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex/nfamatch.nim(236, 21) matchImpl
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex/nfamatch.nim(63, 16) matchImpl
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex/nfamatch.nim(63, 16) reversedMatchImpl
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex/nfamatch.nim(117, 8) reversedMatchImpl
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex.nim(1154, 3) template/generic instantiation of `test` from here
  /home/runner/work/Nim/Nim/pkgstemp/regex/src/regex/nfamatch.nim(117, 8) Error: opcWrDeref internal error
nitely commented 2 years ago

so it's a Nim breaking change?

ringabout commented 2 years ago

@nitely regex works with the devel branch. Imo some precedent PRs are not backported properly to the version-1-6 branch.

narimiran commented 2 years ago

This is now fixed on Nim's side.

I've backported some more PRs.