nitely / nim-regex

Pure Nim regex engine. Guarantees linear time matching
https://nitely.github.io/nim-regex/
MIT License
228 stars 21 forks source link

latest commit makes `nimble install regex` fail => invalid regex.nimble is invalid #18

Closed timotheecour closed 6 years ago

timotheecour commented 6 years ago

nimble install regex

Downloading https://github.com/nitely/nim-regex using git
       Tip: 6 messages have been suppressed, use --verbose to show them.
     Error: Could not read package info file in /tmp/nimble_23655/githubcom_nitelynimregex/regex.nimble;
        ...   Reading as ini file failed with:
        ...     Invalid section: .
        ...   Evaluating as NimScript file failed with:
        ...         ^.

=> could future bugs like this be avoided with a proper check in travis.yml?

nitely commented 6 years ago

I didn't break it AFAIK. It's an issue with latest Nimble probably, nothing I can do about it (not by changing travis anyway), I mean Nimble can break backward compatibility at any time.

timotheecour commented 6 years ago

upon further debugging:

nimble --verbose build
    Setting Nim stdlib prefix to
    Setting Nim stdlib path to /Users/timothee/git_clone/nim/Nim/lib
       Info /Users/timothee/git_clone/timotheecour/timconfig/dots_rename/config/nim.cfg(35, 3) Error: invalid command line option: '--nilseqs'
       Info   --nilseqs:on
     Error: Could not read package info file in /Users/timothee/git_clone/nim/nim-regex/regex.nimble;
        ...   Reading as ini file failed with:
        ...     Invalid section: .
        ...   Evaluating as NimScript file failed with:
        ...         ^.

this happens because I have --nilseqs:on in my ~/.config/nim.cfg NOTE: this --nilseqs:on must be supported in ~/.config/nim.cfg even now that https://github.com/nitely/nim-regex/commit/e69a8cfb0db4638f9989593a41450ad5f8258a84 was commited, because other packages may require (temporarily...) this flag.

I now agree, though, that it's an issue with nimble

timotheecour commented 6 years ago

thanks, indeed works now!