search

nitely / nim-regex

Pure Nim regex engine. Guarantees linear time matching
https://nitely.github.io/nim-regex/
MIT License
228 stars 21 forks source link

nim CI important_packages failure #60

Closed timotheecour closed 4 years ago

timotheecour commented 4 years ago

probably caused by the recent changes: https://github.com/nim-lang/Nim/pull/13865

https://dev.azure.com/nim-lang/255dfe86-e590-40bb-a8a2-3c0295ebdeb1/_apis/build/builds/4019/logs/80

2020-04-04T09:41:33.8575534Z PASS: https://github.com/andreaferretti/react.nim C                ( 4.24 sec)
2020-04-04T09:41:33.8575912Z FAIL: https://github.com/nitely/nim-regex C
2020-04-04T09:41:33.8577041Z Test "https://github.com/nitely/nim-regex" in category "nimble-packages"
2020-04-04T09:41:33.8577375Z Failure: reBuildFailed
2020-04-04T09:41:33.8577583Z package test failed
2020-04-04T09:41:33.8577798Z $ nim c src/regex
2020-04-04T09:41:33.8578074Z Hint: used config file 'd:\a\1\s\config\nim.cfg' [Conf]
2020-04-04T09:41:33.8578458Z Hint: used config file 'd:\a\1\s\config\config.nims' [Conf]
2020-04-04T09:41:33.8578753Z Hint: system [Processing]
2020-04-04T09:41:33.8579001Z Hint: widestrs [Processing]
2020-04-04T09:41:33.8579219Z Hint: io [Processing]
2020-04-04T09:41:33.8579453Z Hint: regex [Processing]
2020-04-04T09:41:33.8579743Z Hint: tables [Processing]
2020-04-04T09:41:33.8580222Z Hint: hashes [Processing]
2020-04-04T09:41:33.8580504Z Hint: math [Processing]
2020-04-04T09:41:33.8580740Z Hint: bitops [Processing]
2020-04-04T09:41:33.8580953Z Hint: macros [Processing]
2020-04-04T09:41:33.8581192Z Hint: algorithm [Processing]
2020-04-04T09:41:33.8581426Z Hint: sequtils [Processing]
2020-04-04T09:41:33.8581648Z Hint: unicode [Processing]
2020-04-04T09:41:33.8581892Z Hint: strutils [Processing]
2020-04-04T09:41:33.8582115Z Hint: parseutils [Processing]
2020-04-04T09:41:33.8582514Z d:\a\1\s\pkgstemp\regex\src\regex.nim(156, 17) Error: cannot open file: pkg/regex/nodetype
2020-04-04T09:41:33.8582818Z 
2020-04-04T09:45:45.5746035Z PASS: https://github.com/arnetheduck/nim-result C                  ( 4.78 sec)
timotheecour commented 4 years ago

probably related: when running locally:

nim c --nonimblepath src/regex
/Users/timothee/git_clone/nim/nim-regex/src/regex.nim(156, 17) Error: cannot open file: pkg/regex/nodetype
  import pkg/regex/nodetype
nitely commented 4 years ago

Apparently pkg/ was never meant for importing local/relative modules https://github.com/nim-lang/Nim/issues/7250 . It makes sense, otherwise I could not import a nimble package instead of a local module with the same name. I should have used ./regex/... or regex/....