niteshpatel / ministocks

Android Stocks Widget
http://niteshpatel.github.io/ministocks
MIT License
52 stars 37 forks source link

fetching data seems stopped working #80

Closed muziofg closed 1 year ago

muziofg commented 1 year ago

today fetching data seems stopped working, I'm unable to see fresh updated stocks prices (nor automatic, nor manual) API hasn't stopped working, for example I can query with success the url

"https://query1.finance.yahoo.com/v7/finance/quote?fields=symbol,regularMarketPrice,regularMarketChange,regularMarketChangePercent,regularMarketVolume,shortName,longName&symbols=META";

I have also tried to install from play store to a clean device a new instance of this app and trying to fetch data for a single ticker without success

I have tried to reproduce the behavior with this simple java SE software, but unfortunately it works for me


import java.net.URL;
import java.net.URLConnection;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;

class StockData{  
    public static void main(String args[]) throws Exception{
        String url = "https://query1.finance.yahoo.com/v7/finance/quote?fields=symbol,regularMarketPrice,regularMarketChange,regularMarketChangePercent,regularMarketVolume,shortName,longName&symbols=META";
        URLConnection connection = new URL(url).openConnection();
        connection.setConnectTimeout(30000);
        connection.setReadTimeout(60000);
        BufferedReader r = new BufferedReader(new InputStreamReader(connection.getInputStream()));  
        String line;
            while ((line = r.readLine()) != null) {
            System.out.println(line);  
        }
    }  
}  

I don't know if, for example, on android platform URLConnection has a different (and banned) user agent

enricodevtest commented 1 year ago

I just wanted to confirm that you are not the only person experiencing this problem. The price updates are not happening right now for me too.

mossi1960 commented 1 year ago

Since 2 days the price updates are not happening for me too.

fabiorauber commented 1 year ago

Mine stopped working as well.

niteshpatel commented 1 year ago

@muziofg looks to be the user agent as you guessed. have pushed an update but Google has put it under view, not sure how long it takes. hopefully that fixes it. thanks for putting effort in to help diagnose

niteshpatel commented 1 year ago

This should be fixed now.

Note that fixing this stuff requires a lot of effort as often not only the logic needs to be fixed, but updated versions of the programs I used for development need to be setup (since this app is not updated frequently) and configured.

If you appreciate the effort please put a 5 star review on the Play store.

Thanks

From: enricodevtest @.> Sent: 27 October 2022 03:34 To: niteshpatel/ministocks @.> Cc: Subscribed @.***> Subject: Re: [niteshpatel/ministocks] fetching data seems stopped working (Issue #80)

I just wanted to confirm that you are not the only person experiencing this problem. The price updates are not happening right now for me too.

Reply to this email directly, <https://github.com/niteshpatel/ministocks/issues/80#issuecomment-1292888411

view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AA52MQ4YMSUPSN5ANVCNMJDWF HSYTANCNFSM6AAAAAARPNDNB4 unsubscribe. You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AA52MQ4WR6M4OEULJLPUZTTWFHSYTA5CNFS M6AAAAAARPNDNB6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS NB7UVW.gif Message ID: @.***>

niteshpatel commented 1 year ago

This should be fixed now.

Note that fixing this stuff requires a lot of effort as often not only the logic needs to be fixed, but updated versions of the programs I used for development need to be setup (since this app is not updated frequently) and configured.

If you appreciate the effort please put a 5 star review on the Play store.

Thanks

From: Fabio Rauber @.> Sent: 27 October 2022 14:25 To: niteshpatel/ministocks @.> Cc: Subscribed @.***> Subject: Re: [niteshpatel/ministocks] fetching data seems stopped working (Issue #80)

Mine stopped working as well.

Reply to this email directly, <https://github.com/niteshpatel/ministocks/issues/80#issuecomment-1293523703

view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AA52MQ34MMDGESXP4675R33WF J7ERANCNFSM6AAAAAARPNDNB4 unsubscribe. You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AA52MQ4A7YMWHTQIDMAMJRLWFJ7ERA5CNFS M6AAAAAARPNDNB6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS NDGNPO.gif Message ID: @.***>

niteshpatel commented 1 year ago

This should be fixed now.

Note that fixing this stuff requires a lot of effort as often not only the logic needs to be fixed, but updated versions of the programs I used for development need to be setup (since this app is not updated frequently) and configured.

If you appreciate the effort please put a 5 star review on the Play store.

Thanks

From: mossi1960 @.> Sent: 27 October 2022 14:25 To: niteshpatel/ministocks @.> Cc: Subscribed @.***> Subject: Re: [niteshpatel/ministocks] fetching data seems stopped working (Issue #80)

Since 2 days the price updates are not happening for me too.

Reply to this email directly, <https://github.com/niteshpatel/ministocks/issues/80#issuecomment-1293523537

view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AA52MQYQFZOWPTWTVWX6IV3WF J7EDANCNFSM6AAAAAARPNDNB4 unsubscribe. You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AA52MQZ2YO2BTDK4Q6UI2ITWFJ7EDA5CNFS M6AAAAAARPNDNB6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS NDGNFC.gif Message ID: < @.> @.>

bencew commented 1 year ago

Thanks for the update, Nitesh! Are you going to initiate to update the F-droid version, too? I've the app installed from there

niteshpatel commented 1 year ago

Hi benecew – probably not. I didn’t load it there in the first place (not sure how)?

From: bencew @.> Sent: 28 October 2022 11:55 To: niteshpatel/ministocks @.> Cc: Nitesh Patel @.>; Comment @.> Subject: Re: [niteshpatel/ministocks] fetching data seems stopped working (Issue #80)

Thanks for the update, Nitesh! Are you going to initiate to update the F-droid version, too? I've the app installed from there

— Reply to this email directly, view it on GitHub https://github.com/niteshpatel/ministocks/issues/80#issuecomment-1294851644 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA52MQ6M7R374F6H7F7SCYDWFOWHVANCNFSM6AAAAAARPNDNB4 . You are receiving this because you commented. https://github.com/notifications/beacon/AA52MQY3OSXGS7BLOXW3IMDWFOWHVA5CNFSM6AAAAAARPNDNB6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSNFXPDY.gif Message ID: @. @.> >

bencew commented 1 year ago

Weird, the F-Droid page is linked here in the readme

niteshpatel commented 1 year ago

I believe F-Droid will pull it automatically at some point.

From: bencew @.> Sent: 28 October 2022 14:50 To: niteshpatel/ministocks @.> Cc: Nitesh Patel @.>; Comment @.> Subject: Re: [niteshpatel/ministocks] fetching data seems stopped working (Issue #80)

Weird, the F-Droid page is linked here in the readme

— Reply to this email directly, view it on GitHub https://github.com/niteshpatel/ministocks/issues/80#issuecomment-1295025367 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA52MQ5FGFJNN2P65BVOT5DWFPKZ3ANCNFSM6AAAAAARPNDNB4 . You are receiving this because you commented. https://github.com/notifications/beacon/AA52MQ2T376CZY5EJK7UUZDWFPKZ3A5CNFSM6AAAAAARPNDNB6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSNGCCNO.gif Message ID: @. @.> >

muziofg commented 1 year ago

This should be fixed now. Note that fixing this stuff requires a lot of effort as often not only the logic needs to be fixed, but updated versions of the programs I used for development need to be setup (since this app is not updated frequently) and configured.

I have seen it (and recognize the effort) by the last commit, now app requires at least Android 6.0 (plus some minimal changes, like enumerated property values), you can update the description on github/stores page to avoid misunderstandings.

In the commit I also have seen that now the app idenfing itself as "Ministocks - Stocks Widget". That's a honest choice, but exposes Ministocks to identification/ban risks, I was thinking more like an identification as Chrome/Firefox

Many thanks to you for the fast bugfixing

niteshpatel commented 1 year ago

Ah good points, will make a note. thank you

morganchristiansson commented 1 year ago

Maybe automating releases to Play Store / F-Droid using Github Actions ís a good idea?

niteshpatel commented 1 year ago

Maybe automating releases to Play Store / F-Droid using Github Actions ís a good idea?

The app is updated too infrequently for the effort to maintain this to be worthwhile. Also releasing to play store often includes additional steps some of which are based on Google policy changes etc. that frequently require manual unpredictable steps.

morganchristiansson commented 1 year ago

Having a pipeline that is not dependent on local tooling would make infrequent releases easier. Just a friendly suggestion.

niteshpatel commented 1 year ago

Appreciate the suggestion but totally disagree!