search

nithinbekal / openlibrary

Elixir client for Open Library Rest API
6 stars 2 forks source link

Find authors by olid #2

Open nithinbekal opened 7 years ago

nithinbekal commented 7 years ago

Implement Openlibrary.Author.find_by_olid/1.

Refer:

nithinbekal commented 7 years ago

Fixed via #6. Thanks @nithinjos!

nithinjos commented 7 years ago

Thanks and Cheers @nithinbekal , but I'm afraid I didn't add the find_by_olid function which was the 2nd issue reported. Let me create one more PR ?

nithinbekal commented 7 years ago

That would be awesome! I saw the find_by_oclc function and misread that as olid. :)

nithinjos commented 7 years ago

I'll do it soon. Also, apart from these three raised issues, what are the other functions to be added to Openlibrary? I'd like to work on it :) :)

nithinbekal commented 7 years ago

There are things in the API that aren't included yet, like searching multiple keys, looking up authors, etc. I'll add them as issues - feel free to take them up. :)

nithinjos commented 7 years ago

Sure! @nithinbekal :) Cheers.