nithinmurali / pygsheets

Google Sheets Python API v4
https://pygsheets.readthedocs.io/en/latest
Other
1.51k stars 220 forks source link

add set_basic_filter_func #523

Closed rariyama closed 2 years ago

rariyama commented 2 years ago

What I did

This PR is related to the issue #509. This function can support SetBasicFilterRequest API with custom_request.

What I confirmed

I also implemented unit test with some cases. These can cover the supporting models like GridRange, SortSpec and FilterSpec . In addition to that, I confirmed that API actions worked correctly on my spreadsheet.

What I want you to confirm

Please check the items below.

This is the first time I issued a PR on this repository, so I'm sorry in advance if there is any inconvenience.

nithinmurali commented 2 years ago

Looks good overall. Added some minor comments.

nithinmurali commented 2 years ago

Awesome. Everything looks good.