search

nithinmurali / pygsheets

Google Sheets Python API v4
https://pygsheets.readthedocs.io/en/latest
Other
1.5k stars 220 forks source link

Add initial Pie Chart implementation #591

Closed JohnBarton27 closed 7 months ago

JohnBarton27 commented 8 months ago

I wanted to add a Pie Chart to a Sheet I was populating using pygsheets. I added an initial implementation here that extends the Chart class with a few key changes. Definitely a little bit of duplicated/similar code in the methods that get overridden in the PieChart class - open to suggestions if you want a deeper re-write to abstract some of that out. Hopefully this can also help build a pattern for other future "non-basic" Charts to get support.

JohnBarton27 commented 7 months ago

Overall looks good. just some minor comments.

Sounds good, just pushed fixes!

nithinmurali commented 7 months ago

Awesome! thanks for the PR.