Feat invalidate transport

nithril / smtp-connection-pool

SMTP Connection Pool

Apache License 2.0

47 stars 19 forks source link

Feat invalidate transport #18

Closed evigeant closed 5 years ago

evigeant commented 5 years ago

This PR adds the possibility to invalidate ClosableSmtpConnection instead of returning them in the pool.

My use case is:

I do not want to testOnBorrow or testOnReturn since this impacts performance negatively
If there is no exception when sending emails, return the connection to the pool, it appears to still be good
If there is an exception, do not return the connection to the pool, it might be bad

nithril commented 5 years ago

Thanks for this PR. Have you consided to implement a setInvalidateConnectionOnException with a try/catch that would take care of flagging the connection in DefaultClosableSmtpConnection#doSend ?

evigeant commented 5 years ago

That is a great idea, I forced push the branch to discard the previous functionality and commit the new functionality