Added re-render - Githubissues

nitin42 / react-imgpro

📷 Image Processing Component for React

2.18k stars 83 forks source link

Added re-render #10

Closed Sunshine168 closed 6 years ago

Sunshine168 commented 6 years ago

emmm, btw i found out two points

comments only in with-comments branch ~, but thought comments should be in master will be better . or i will add comments in comments branch
Seem my workspace format the code

nitin42 commented 6 years ago

Thanks! Can you show me a gif of this ? would be much better to interpret the results.

Sunshine168 commented 6 years ago

imgpro

gif is showing process in worker . And i keeping thinking how to improve experience for this feature

And i updated the demo in public folder

nitin42 commented 6 years ago

Exciting!

nitin42 commented 6 years ago

I'll review your PR sometime later today or may be tomorrow (just a little busy with some other work). Awesome job!

Thanks!

Sunshine168 commented 6 years ago

okay !

Sunshine168 commented 6 years ago

~ hi any news ?

Sunshine168 commented 6 years ago

BTW i am interesting be a maintainers for this lib

nitin42 commented 6 years ago

Added you as a collaborator on this project. Thank you so much for your contributions!

Sunshine168 commented 6 years ago

🤣 Glad to hear that

Sunshine168 commented 6 years ago

Hi @nitin42 I plan to add unit test for this feat and publish a new version . What is a good way for i to contact you , using email or twitter ? And did you having some work about #8