Access img ref/reference

[darkowic]

Hello!

I need to access reference of the rendered img component. It is impossible right now.

We have 2 options:

• Add new prop innerRef/imgRef/etc which will be passed to img component
• Use React 16 forwardRef API to pass ref to the rendered img component

What do you think? Since this component is rendering img component directly, I think the second solution will be more appropriate.

[nitin42]

Seems doable! Thanks for the suggestion. Can you create a pull request for this ? @Sunshine168 this is interesting, what do you think ?

[Sunshine168]

Absolutely, ref is useful, and recommend to use forwardRef Api.

[Sunshine168]

~~BTW forwardRef Api is available in React 16.3~ You can use create-react-ref for this feat

[Sunshine168]

@darkowic Did you like to create a PR about this feat ~ or I will work on this .

[darkowic]

I will handle this in few days, ok?

sob., 15 wrz 2018, 06:52 użytkownik ZiYingMai notifications@github.com napisał:

@darkowic https://github.com/darkowic Did you like to create a PR about this feat ~ or I will work on this .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nitin42/react-imgpro/issues/20#issuecomment-421530871, or mute the thread https://github.com/notifications/unsubscribe-auth/AK-jNe04OPSXyF0UGVp9WUkkK2iO7N11ks5ubIeJgaJpZM4Wg8gj .

[Sunshine168]

@LukasDrgon Grateful~ I just make sure you take it

[Sunshine168]

Hi any news about this ~

[Sunshine168]

Done #29