search

nitin42 / react-imgpro

📷 Image Processing Component for React
2.18k stars 83 forks source link

Adding cropping functionality #28

Closed silverlight513 closed 5 years ago

silverlight513 commented 5 years ago

On top of adding the cropping functionality, I've also upgraded jimp to its latest version (0.5.6).

silverlight513 commented 5 years ago

@nitin42 @Sunshine168 Is this project still maintained? There's some more functionality I'd like to add to on top of this

Sunshine168 commented 5 years ago

Yes , i will check your PR soon, PR is always appreciated . Next time you can ping me

Sunshine168 commented 5 years ago

@silverlight513 Did you mind upgrade jimp version in package.json and add the crop method in doc too?

silverlight513 commented 5 years ago

I'll get onto that now. I forgot to go back and add that in now. I might have also found a bug I want to look into

silverlight513 commented 5 years ago

@Sunshine168 What is the reason behind adding the width and height to the img tag when rendering the <ProcessImage /> as a style attribute? I found that when cropping it stops the image rendering to the correct size.

Sunshine168 commented 5 years ago

After using resize it should be the actual width and height

silverlight513 commented 5 years ago

I think I need to do some more digging into how resize works because it's stopping the cropping from looking like it's worked properly.

silverlight513 commented 5 years ago

I've added the changes you asked for but can you hold off merging until I've found out the problem I'm having with width and height as its a bug

Sunshine168 commented 5 years ago

Ok Later you can ping me , actually show the gif for how it work is appreciated for me

silverlight513 commented 5 years ago

@Sunshine168 fix for the width/height style attribute is there. Can be merged now! Not sure how a gif would help, cropping is pretty self explanatory imo

silverlight513 commented 5 years ago

@Sunshine168, would it be possible to get a 1.4.0 release with this included sometime soon?

Sunshine168 commented 5 years ago

@silverlight513 have been release in 1.3.11

silverlight513 commented 5 years ago

@Sunshine168 Thanks for the release. Just out of curiosity, why does this project choose not to follow semver?

silverlight513 commented 5 years ago

@Sunshine168 I just noticed that the tags don't match the releases on npm. This isn't the place to discuss it but I just wanted to pass it by you and check if you wanted me to open an issue for this?

Sunshine168 commented 5 years ago

Sorry about that , released version is 1.3.12 . You have any question ,just open an issue to talk about it