search

nitin42 / react-imgpro

đź“· Image Processing Component for React
2.18k stars 83 forks source link

Allowing errors from Jimp to be passed back to the user #33

Closed silverlight513 closed 5 years ago

silverlight513 commented 5 years ago

Was getting unhandled promise errors from jimp.read and getSize methods.

Added a few catch statements so we can pass errors back to the processImage callback.

silverlight513 commented 5 years ago

@Sunshine168 got another PR for you with some added error handling

Sunshine168 commented 5 years ago

Thanks and I will check it later and seem your commit 「Merge remote-tracking branch 'source/master'」 is not correct ? It should be just rebase to your local branch for remote master .

silverlight513 commented 5 years ago

That's an automatic commit name from pulling in latest code. I had conflicts on my branch and therefore had to do a merge

Sunshine168 commented 5 years ago

Thanks !