nitinthewiz / ghost-phantom

Phantom theme for Ghost
MIT License
433 stars 121 forks source link

Add ease-in-out transition to links #15

Closed thiphariel closed 10 years ago

thiphariel commented 10 years ago

Hello.

I think you theme is really cool and smooth, but see no color transition on links makes me sad, and I think it's really fits with your theme thoughts, aren't you ?

Anyway, thanks for it !

haydenbleasel commented 10 years ago

Hey @thco, awesome find - I totally agree! Only 2 things need to be changed:

1) The transition rule doesn't need to be applied to a:hover, only a. This is because pseudo-selectors like :hover, :visited and :focus all inherit from the specified tag. So yeah, just remove that second rule and it'll still work. Too easy :)

2) We'll need vendor prefixes, so I've generated the code for you already:

-webkit-transition: color .2s ease-in-out;
transition: color .2s ease-in-out;

Other than that I'm good to merge! Nice work :)

thiphariel commented 10 years ago

No problem, I'll fix that, gimme few minutes :) And thanks for the trick, I'm not really CSS pro !

Edit : Here you go !

haydenbleasel commented 10 years ago

Noice