search

nitish24p / react-worker-image

React component to fetch image resources via web workers 🤖🤖
MIT License
232 stars 18 forks source link

let user pass extra attributes #16

Open hosmelq opened 6 years ago

nitish24p commented 6 years ago

can you put forth a use case?

hosmelq commented 6 years ago

@nitish24p if you need to pass any other attribute to <img /> you can not.

For example, I need to pass custom alt and aria attributes.

manjula-dube commented 6 years ago

So you want to have a support to pass alt and aria attributes as props Right?

kurtextrem commented 6 years ago

This is a nice PR, as it allows every prop a user wants. For example height, width and the new decoding as well. (Decoding ref is here: https://html.spec.whatwg.org/multipage/images.html#image-decoding-hint - afaik only Chrome implemented it yet)

hosmelq commented 6 years ago

Yes @manjula91 and any other attributes.