Support for various clients

nitishm / go-rejson

Golang client for redislabs' ReJSON module with support for multilple redis clients (redigo, go-redis)

MIT License

343 stars 47 forks source link

Support for various clients #29

Closed Shivam010 closed 5 years ago

Shivam010 commented 5 years ago

Moving forward on the proposed work in the issue https://github.com/nitishm/go-rejson/issues/27#issuecomment-453861407

The project now, is all set to implement the ReJSON commands for various clients.

Checklist to implement gomodule/redigo client:

[x] Interface setup and other stuffs to be used during client implementation
[x] ~~Abstracting options for other commands like JSON.ARRINDEX and JSON.ARRPOP, as done forJSON.GET and JSON.SET~~

Edited: I think their abstraction is not much required, they are very well maintained rigthnow
[x] Adding proper examples and details in comments so that the godoc of the repo will be improved
[x] Implementation of commands in gomodule/redigo
[x] Adding proper test cases for clients

Similarly, for other clients:

[x] gomodule/redigo
[x] go-redis/redis

Support for mediocregopher/radix is moved to the future roadmap

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 85

108 of 108 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.05%) to 100.0%

Totals
Change from base Build 73:	7.05%
Covered Lines:	118
Relevant Lines:	118

💛 - Coveralls

Shivam010 commented 5 years ago

golint forces not to use underscores in Go names

I think that we should consider using underscore, since it clearly signifies the parent-child relationship concept. i.e. should increase the min-confidence of golint to 1

Just a suggestion

nitishm commented 5 years ago

golint forces not to use underscores in Go names

I think that we should consider using underscore, since it clearly signifies the parent-child relationship concept. i.e. should increase the min-confidence of golint to 1

Just a suggestion

If you can make golint pass by setting min-confidence 1, then go for it !

nitishm commented 5 years ago

@Shivam010 Is this still a Work In Progress or are you done with supporting redigo ?

Shivam010 commented 5 years ago

@nitishm I think, now the project is ready for its deployment, with two redis client support,

gomodule/redigo
go-redis/redis

The coding part for both the clients are done, only the examples are left to implement.

And also, the use of underscores is removed from the project 😅

nitishm commented 5 years ago

Great job @Shivam010 ! 🥇