Closed breno12321 closed 2 years ago
LGTM. @Shivam010 if there are no objections let's get this in?
The GitHub action should have run for the pr, right? Why hasn't it run?
I can further on add the GitHub Action but by the way the tests weren't passing before the change π . Also I've known golang for 2 days so I'll have to study to fix them π€·πΌββοΈ hehe
@Shivam010 I created the #58 check if its this what you mean π
@breno12321 All the tests were successful earlier, have a look here https://github.com/nitishm/go-rejson/runs/2264211335?check_suite_focus=true I have approved the request to run the tests in #58
Ah sorry my bad π I ran in my fork master and failed for some reason π€
Totals | |
---|---|
Change from base Build 716585563: | 0.0% |
Covered Lines: | 131 |
Relevant Lines: | 133 |
@breno12321 All the tests were successful earlier, have a look here https://github.com/nitishm/go-rejson/runs/2264211335?check_suite_focus=true I have approved the request to run the tests in #58
Apparently was related to the rejson version @Shivam010 good to go β πΊπΌ
Ok, tests are passing so, I am accepting the changes
Thanks guys!! Lets continue the journey to learn go hehe
Context
As we know in the issue #56 some characters when read from the database are not being processing as valid UTF-8 Characters. So this fixes it to handle the full length of the data representation for them
Closes #56