nitishm / go-rejson

Golang client for redislabs' ReJSON module with support for multilple redis clients (redigo, go-redis)
MIT License
344 stars 47 forks source link

Fix encoding to work with Cyrillic and Portuguese accentuation #57

Closed breno12321 closed 2 years ago

breno12321 commented 2 years ago

Context

As we know in the issue #56 some characters when read from the database are not being processing as valid UTF-8 Characters. So this fixes it to handle the full length of the data representation for them

Closes #56

nitishm commented 2 years ago

LGTM. @Shivam010 if there are no objections let's get this in?

Shivam010 commented 2 years ago

The GitHub action should have run for the pr, right? Why hasn't it run?

breno12321 commented 2 years ago

I can further on add the GitHub Action but by the way the tests weren't passing before the change πŸ‘€ . Also I've known golang for 2 days so I'll have to study to fix them πŸ€·πŸΌβ€β™‚οΈ hehe

image

breno12321 commented 2 years ago

@Shivam010 I created the #58 check if its this what you mean πŸ‘€

Shivam010 commented 2 years ago

@breno12321 All the tests were successful earlier, have a look here https://github.com/nitishm/go-rejson/runs/2264211335?check_suite_focus=true I have approved the request to run the tests in #58

breno12321 commented 2 years ago

Ah sorry my bad πŸ™ƒ I ran in my fork master and failed for some reason πŸ€”

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1697933704


Totals Coverage Status
Change from base Build 716585563: 0.0%
Covered Lines: 131
Relevant Lines: 133

πŸ’› - Coveralls
breno12321 commented 2 years ago

@breno12321 All the tests were successful earlier, have a look here https://github.com/nitishm/go-rejson/runs/2264211335?check_suite_focus=true I have approved the request to run the tests in #58

Apparently was related to the rejson version @Shivam010 good to go βœ… πŸ•ΊπŸΌ

Shivam010 commented 2 years ago

Ok, tests are passing so, I am accepting the changes

breno12321 commented 2 years ago

Thanks guys!! Lets continue the journey to learn go hehe