Add Github actions for Pull Requests

nitishm / go-rejson

Golang client for redislabs' ReJSON module with support for multilple redis clients (redigo, go-redis)

MIT License

340 stars 46 forks source link

Add Github actions for Pull Requests #58

Closed breno12321 closed 2 years ago

breno12321 commented 2 years ago

Oh sorry I thought I didn't sent them together

breno12321 commented 2 years ago

@Shivam010 Uhm why it still don't pass even though its just github actions change 🤔

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1697907725

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0%) to 98.496%

Totals
Change from base Build 716585563:	0.0%
Covered Lines:	131
Relevant Lines:	133

💛 - Coveralls

Shivam010 commented 2 years ago

It's the version issue, we are using the latest version of redislabs/rejson (i.e 2.0.6)

Redislabs have changed some command responses after 1.0.8 which is causing failures in our tests. I have run them locally with 1.0.8, they are working.

For now, limiting the support to 1.0.8 and merging changes

Shivam010 commented 2 years ago

Ignoring the code-analysis / staticcheck too.

breno12321 commented 2 years ago

Thanks <3