nitishm / go-rejson

Golang client for redislabs' ReJSON module with support for multilple redis clients (redigo, go-redis)
MIT License
343 stars 47 forks source link

Adding support for different types of connections provided by libraries #62

Closed Shivam010 closed 2 years ago

Shivam010 commented 2 years ago

Checking ClusterClient support with go-redis UniversalClient

Closes #53 #63

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1854658964


Totals Coverage Status
Change from base Build 1758251414: 0.0%
Covered Lines: 126
Relevant Lines: 133

💛 - Coveralls
Shivam010 commented 2 years ago

go-redis provides 4 different types of protocols to connect to Redis

Similarly, Redigo provides a single method:

And as we only use Do method of both the clients. Hence, in order to support these different types of connections in each client, abstracting the required method is the only feasible option

Shivam010 commented 2 years ago

This removes the direct dependency on the corresponding libraries' clients for obtaining a connection

Shivam010 commented 2 years ago

Closes #63

hirenvadalia commented 2 years ago

@Shivam010 +1 for solution, this solution will work with all types of clients