nitishm / vegeta-server

A RESTful API server for vegeta, a load testing tool written in Go.
MIT License
63 stars 17 forks source link

Returns the status codes in the report responses #20

Closed andrysds closed 5 years ago

andrysds commented 5 years ago

for issue #9

nitishm commented 5 years ago

@andrysds Can you fix the failures reported in Travis.

$ make validate
golangci-lint run
internal/vegeta/report.go:131:16: Error return value of `json.Unmarshal` is not checked (errcheck)
    json.Unmarshal(buf.Bytes(), &m)
                  ^
internal/vegeta/report.go:135:16: Error return value of `json.Unmarshal` is not checked (errcheck)
    json.Unmarshal(osd, &oldStatusCodes)
                  ^
internal/vegeta/report.go:148:29: Error return value of `(*encoding/json.Encoder).Encode` is not checked (errcheck)
    json.NewEncoder(buf).Encode(m)
                               ^
make: *** [validate] Error 1
The command "make validate" exited with 2.
nitishm commented 5 years ago

Great job @andrysds !! Thanks ! 🎉

andrysds commented 5 years ago

Thanks @nitishm !! 🎉