Closed isaacnboyd closed 5 years ago
This is awesome ! Dont worry about the multiple commits. I do that all the time. My git-fu is pretty week too ! 😉
The changes look good. Can I ask you to add make container
, make container_run
and make container_clean
targets to the Makefile ? Make them do what you specified in the README.md doc.
It would make it easier for the user to kick-off and run a container using make
.
Once you have that we can also add it to the README.md instructions.
Yes! I'll get on that. That sounds awesome
LGTM
Oh boy. I'm still learning git. I had some problems rebasing but I understand it now.
I reverted all my commits and am making a new pull request. I also added one more thing on the permissions for docker-entrypoint.
Sorry for the multiple pull requests.