all docker stuff - Githubissues

nitishm / vegeta-server

A RESTful API server for vegeta, a load testing tool written in Go.

MIT License

63 stars 17 forks source link

all docker stuff #37

Closed isaacnboyd closed 5 years ago

isaacnboyd commented 5 years ago

Oh boy. I'm still learning git. I had some problems rebasing but I understand it now.

I reverted all my commits and am making a new pull request. I also added one more thing on the permissions for docker-entrypoint.

Sorry for the multiple pull requests.

nitishm commented 5 years ago

This is awesome ! Dont worry about the multiple commits. I do that all the time. My git-fu is pretty week too ! 😉

The changes look good. Can I ask you to add make container, make container_run and make container_clean targets to the Makefile ? Make them do what you specified in the README.md doc.

It would make it easier for the user to kick-off and run a container using make.

Once you have that we can also add it to the README.md instructions.

isaacnboyd commented 5 years ago

Yes! I'll get on that. That sounds awesome

nitishm commented 5 years ago

LGTM