add id to text report - Githubissues

nitishm / vegeta-server

A RESTful API server for vegeta, a load testing tool written in Go.

MIT License

63 stars 17 forks source link

add id to text report #45

Closed enc closed 5 years ago

enc commented 5 years ago

fixes #40

nitishm commented 5 years ago

@enc Looks like the linter didn't like the function name. Can you fix the error so that we can get this merged ?

enc commented 5 years ago

sure a drop from 100% 😉

nitishm commented 5 years ago

@enc what's with coverall showing the drop ? 🤔

enc commented 5 years ago

When I look at the reports dir in master,t here is no test. Adding a test seems to put it on the map of coveralls. Therefore having effectively more tests will reduce the number.

nitishm commented 5 years ago

Anyways changes look good to me. Great job !