nitishm / vegeta-server

A RESTful API server for vegeta, a load testing tool written in Go.
MIT License
63 stars 17 forks source link

fixed #47: Moved REST API usage examples to /docs/usage.md #48

Closed jatinkumarg closed 5 years ago

jatinkumarg commented 5 years ago

Moved the REST API usage examples from the README.md to a /docs/usage.md.

jatinkumarg commented 5 years ago

@nitishm Can you please review my new changes?

nitishm commented 5 years ago

@jatinkumarg it looks good now. I forgot to ask you to add a link to the docs in the README.md.

Under the subsection for Usage add a link to docs.md

jatinkumarg commented 5 years ago

@nitishm you mean adding a Usage.md link to Readme.md ?

Can you also tell me how can I do it?

nitishm commented 5 years ago

@nitishm you mean adding a Usage.md link to Readme.md ?

Can you also tell me how can I do it?

Sure, I added the suggestion for change in the README.md change review.

jatinkumarg commented 5 years ago

@nitishm Thanks for the help!

I have made the required changes. Can you please review it?

nitishm commented 5 years ago

@jatinkumarg Sorry I mixed up the braces. Suggested the fix.

jatinkumarg commented 5 years ago

@nitishm I have updated the brackets in README.md

nitishm commented 5 years ago

LGTM. Great job @jatinkumarg