Repobrowser closes when escape is pressed to cancel an edit

nitishmishra1992 / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn

0 stars 0 forks source link

Repobrowser closes when escape is pressed to cancel an edit #669

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

When editing a label in the tree view (press F2) and then the edit is cancelled 
via the escape key, the repobrowser closes too.

Original issue reported on code.google.com by tortoisesvn on 9 Oct 2014 at 4:39

GoogleCodeExporter commented 9 years ago

Original comment by tortoisesvn on 9 Oct 2014 at 5:22

Changed state: Started
Added labels: Milestone-1.8.9

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r25932.

Original comment by tortoisesvn on 9 Oct 2014 at 6:20

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r25933.

Original comment by tortoisesvn on 9 Oct 2014 at 6:42

GoogleCodeExporter commented 9 years ago

The faulty behaviour (repobrowser closes on pressing ESC) is fixed with r25933

But there are some undesirable side effects:

* renaming is not possibly anymore by key press (F2) only by mouse click
* when a file is selected (on the right pane) while focus is on the tree view 
(left pane) pressing F2 causes editing the *file* name, not the folder name. 
This is not expected since focus is on the folder, not on the file.

Original comment by krempli...@googlemail.com on 3 Nov 2014 at 1:29

GoogleCodeExporter commented 9 years ago

That's not a side effect: renaming with F2 never worked on the tree view.
But I'll add it...

Original comment by tortoisesvn on 3 Nov 2014 at 6:30

GoogleCodeExporter commented 9 years ago

Sorry, I did not remember correctly that there was no F2 keyboard shortcut 
before. Probably I mixed it up with Windows Explorer. So thanks a lot for 
adding this keyboard shortcut for tree view, too!

Original comment by krempli...@googlemail.com on 4 Nov 2014 at 12:05