search

nitkkr-dev / nitkkr

This repo contains both the front-end and back-end code for NITKKR's new website
https://nitkkr-dev.vercel.app
14 stars 2 forks source link

feat: added # button to heading #155

Open heydoyouknowme0 opened 4 months ago

heydoyouknowme0 commented 4 months ago

its firefox again, I could have just used a span(dont know which is better semantically) but I need something to provide that padding in between, cannot use padding in parent in cause it will take space in the parent container, margin/padding in link also causes undesirable behaviours. content disappears from the dom when hidden feels the most elegant here

heydoyouknowme0 commented 4 months ago

Some styling fixes remain

you removed the comp from the button, it there any problem with that cause that was the best fix to the problem that got introduced now

GetPsyched commented 4 months ago

<Comp> in the code corresponds to the heading we're using. It doesn't feel right to have <h2> for the heading and then another <h2> for a button?

GetPsyched commented 4 months ago

Uh, @heydoyouknowme0?

heydoyouknowme0 commented 4 months ago

I've spent a lot of time on this, using comp or adding a span(or something to encompass it, then styling it) is the only way I could find to make it work as intended.

Latest code still has problems with making the gap unclickable which weren't present before IMG_20240509_160912338_HDR

GetPsyched commented 4 months ago

If we want to make the gap unclickable we can just add a margin instead of a padding, no?

heydoyouknowme0 commented 4 months ago

Nope then hover isn't registered