search

nitkkr-dev / nitkkr

This repo contains both the front-end and back-end code for NITKKR's new website
https://nitkkr-dev.vercel.app
14 stars 2 forks source link

fix: Hamburger modal hides behind page navbar #130 #173

Open som-04 opened 2 months ago

som-04 commented 2 months ago

image image

it's happening when kept blank, numeric values aren't changing anything. so can we just remove z index for the drop down?

GetPsyched commented 2 months ago

Are you putting the values as a string? See how the others are put: https://github.com/nitkkr-dev/nitkkr/blob/1f9bf3972eaa0754b7415bb37b04e299b08b3c0e/tailwind.config.ts#L53-L55

The current z-nav also works with this. There's no possible way it doesn't work as long as you use the same syntax with the same types as this.

som-04 commented 2 months ago

yeah the values were entered as a string. it goes behind on entering any value, but obviously we can't remove nav, so... can we just remove z-nav from here? https://github.com/nitkkr-dev/nitkkr/blob/1f9bf3972eaa0754b7415bb37b04e299b08b3c0e/components/image-header.tsx#L53

GetPsyched commented 2 months ago

We would not remove z-nav, it's there for a reason.